captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r333424085
########## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/auth/TestLdapAuthenticationProviderImpl.scala ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.livy.thriftserver.auth + +import javax.security.sasl.AuthenticationException + +import org.apache.directory.server.annotations.CreateLdapServer +import org.apache.directory.server.annotations.CreateTransport +import org.apache.directory.server.core.annotations.ApplyLdifs +import org.apache.directory.server.core.annotations.ContextEntry +import org.apache.directory.server.core.annotations.CreateDS +import org.apache.directory.server.core.annotations.CreatePartition +import org.apache.directory.server.core.integ.AbstractLdapTestUnit +import org.apache.directory.server.core.integ.FrameworkRunner +import org.junit.Assert +import org.junit.Before +import org.junit.Test +import org.junit.runner.RunWith + +import org.apache.livy.LivyConf + +/** + * This unit test verifies the functionality of LdapAuthenticationProviderImpl. + */ +@RunWith(classOf[FrameworkRunner]) +@CreateLdapServer(transports = Array(new CreateTransport(protocol = "LDAP", address = "localhost"))) +@CreateDS(allowAnonAccess = true, partitions = Array(new CreatePartition(name = "Test_Partition", + suffix = "dc=example,dc=com", contextEntry = new ContextEntry(entryLdif = "dn: dc=example," + + "dc=com \ndc: example\nobjectClass: top\n" + "objectClass: domain\n\n")))) +@ApplyLdifs(Array("dn: uid=bjones,dc=example,dc=com", "cn: Bob Jones", "sn: Jones", + "objectClass: inetOrgPerson", "uid: bjones", "userPassword: p@ssw0rd")) +class TestLdapAuthenticationProviderImpl extends AbstractLdapTestUnit { + private var handler: LdapAuthenticationProviderImpl = null + private var user = "bjones" + private var pwd = "p@ssw0rd" + val livyConf = new LivyConf() + + @Before + @throws[Exception] + def setup(): Unit = { + livyConf.set(LivyConf.THRIFT_AUTHENTICATION, "ldap") + livyConf.set(LivyConf.THRIFT_LDAP_AUTHENTICATION_BASEDN, "dc=example,dc=com") + livyConf.set(LivyConf.THRIFT_LDAP_AUTHENTICATION_URL, String.format("ldap://%s:%s";, "localhost", + AbstractLdapTestUnit.getLdapServer.getPort.toString)) + livyConf.set(LivyConf.THRIFT_LDAP_AUTHENTICATION_USERFILTER, "bjones,jake") + } + + @Test(timeout = 60000) + @throws[AuthenticationException] + def testAuthenticatePasses(): Unit = { + Review comment: Method needs appropriate blank lines to make the logic clearer ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
