captainzmc commented on a change in pull request #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain URL: https://github.com/apache/incubator-livy/pull/236#discussion_r334263458
########## File path: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/auth/ldap/UserFilter.scala ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.livy.thriftserver.auth.ldap + +import javax.security.sasl.AuthenticationException + +import org.apache.livy.{LivyConf, Logging} + +/** + * A factory for a Filter based on a list of allowed users. + * The produced filter object filters out all users that are not on the provided in + * Livy configuration list. + */ +class UserFilter(conf: LivyConf) extends Filter with Logging { + private val userFilterStr = conf.get(LivyConf.THRIFT_LDAP_AUTHENTICATION_USERFILTER) Review comment: This conf.get usage is the same as others that livy used before, and we’d batter keep it the same here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
