andrasbeni commented on a change in pull request #289:
URL: https://github.com/apache/incubator-livy/pull/289#discussion_r446670999
##########
File path:
scala-api/src/main/scala/org/apache/livy/scalaapi/ScalaJobHandle.scala
##########
@@ -190,6 +190,19 @@ class ScalaJobHandle[T] private[livy] (jobHandle:
JobHandle[T]) extends Future[T
getJavaFutureResult(jobHandle, atMost)
this
}
+
+ // These two methods must be implemented in Scala 2.12. They're implemented
as a no-op here
Review comment:
In Scala 2.12 these two new methods ([see
source](https://github.com/scala/scala/blob/v2.12.10/src/library/scala/concurrent/Future.scala#L248-L268
)) were added to the trait `Future`. As a result, `ScalaJobHandle`, which
extends Future needs to implement them.
At the same time I am not sure what @tprelle means by "the two subclasses
below". AFAICT `ScalaJobHandle` does not have any subclasses.
Also, I wouldn't say throwing an exception is a no-op. I suggest "They are
implemented as unsupported operations here" if they are really not going to be
[implemented](https://github.com/scala/scala/blob/v2.12.10/src/library/scala/concurrent/impl/Promise.scala#L31-L48).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
