> On April 22, 2015, 10:48 p.m., Ben Mahler wrote: > > include/mesos/scheduler/scheduler.proto, line 113 > > <https://reviews.apache.org/r/32845/diff/3/?file=939973#file939973line113> > > > > And removes the framework? > > > > Do you want to align the comments so the `//` characters are lined up?
done. > On April 22, 2015, 10:48 p.m., Ben Mahler wrote: > > include/mesos/scheduler/scheduler.proto, line 211 > > <https://reviews.apache.org/r/32845/diff/3/?file=939973#file939973line211> > > > > s/UNSUBSCRIBE/TEARDOWN/ here? Could you do a grep just in case anything > > else was missed? good catch. did a grep too. this was the only one. > On April 22, 2015, 10:48 p.m., Ben Mahler wrote: > > src/tests/scheduler_tests.cpp, line 654 > > <https://reviews.apache.org/r/32845/diff/3/?file=939978#file939978line654> > > > > Hm.. can you add a comment above this as to why it's needed? doesn't look like it's needed. not sure why i added it. deleted it. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/#review81232 ----------------------------------------------------------- On April 22, 2015, 9:43 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32845/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 9:43 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Renamed UNREGISTER call to UNSUBSCRIBE for consistency. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/examples/low_level_scheduler_libprocess.cpp > 63d34eefb60d13fe2b82905c1cec9b762340e997 > src/examples/low_level_scheduler_pthread.cpp > 6d1f938660c02db75bfcbf7c8de0d941cff1920d > src/master/master.cpp f3462d15005e24ab28e8265484b0d3810f21bd47 > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32845/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
