----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33465/#review81544 -----------------------------------------------------------
Ship it! Can you file the follow-up tickets for correctly setting 'uuid' and add a TODO on the existing hacks here an in sched.cpp? Would love to see the hacks removed in a future version! Also, looks like we need a new test for this case, yes? Mind sending a separate review for that before committing this one? - Ben Mahler On April 23, 2015, 5:48 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33465/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 5:48 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Now that TaskStatus has 'uuid', we don't need it in UPDATE. It will also make > the ACKNOWLEDGE semantics easier. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/examples/low_level_scheduler_libprocess.cpp > 63d34eefb60d13fe2b82905c1cec9b762340e997 > src/examples/low_level_scheduler_pthread.cpp > 6d1f938660c02db75bfcbf7c8de0d941cff1920d > src/scheduler/scheduler.cpp bd9fced0f58aa3bc0ff147dbefb77cea4734a79e > > Diff: https://reviews.apache.org/r/33465/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
