----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398/#review83285 -----------------------------------------------------------
Bad patch! Reviews applied: [32139, 32140, 32149, 32150, 29748, 32333] Failed command: ./support/apply-review.sh -n -r 32333 Error: 2015-05-11 20:54:00 URL:https://reviews.apache.org/r/32333/diff/raw/ [16704/16704] -> "32333.patch" [1] error: patch failed: src/tests/hierarchical_allocator_tests.cpp:39 error: src/tests/hierarchical_allocator_tests.cpp: patch does not apply error: patch failed: src/tests/reservation_tests.cpp:286 error: src/tests/reservation_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On May 11, 2015, 8:36 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32398/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 8:36 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-2491 > https://issues.apache.org/jira/browse/MESOS-2491 > > > Repository: mesos > > > Description > ------- > > * Added `isDynamicallyReserved(resource)` which returns true if the resource > is a dynamic reservation. > * Added the `isDynamicallyReserved` condition onto `needCheckpointing`. > * Updated the `applyCheckpointedResources` to consider dynamic reservations. > * Added tests. > > > Diffs > ----- > > include/mesos/resources.hpp 4c036d36e0e8ab3852786dd32b2d983d45891624 > src/common/resources.cpp 235930ff2dbb3ea49a3a0696dc070f2bd56fba4b > src/common/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 > src/tests/reservation_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/32398/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
