----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34016/#review83299 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/34016/#comment134222> unique_ptr is not a POD, so this will still try to run the destructor of the function during exit of the program. Can you just use a raw pointer here and leak it? (Not ideal but we use this in many places) - Ben Mahler On May 9, 2015, 5:07 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34016/ > ----------------------------------------------------------- > > (Updated May 9, 2015, 5:07 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Change the type of signaledWrapper to unique_ptr > > > Diffs > ----- > > src/slave/slave.cpp bf290bfd7d9a59ce7197ce34cbd8cf42e7dd17a3 > > Diff: https://reviews.apache.org/r/34016/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > >
