> On May 1, 2015, 10:43 a.m., Jie Yu wrote: > > src/linux/ns.hpp, line 305 > > <https://reviews.apache.org/r/33746/diff/1/?file=947057#file947057line305> > > > > Consider s/stringify/names/ ?
I'd expect names() to return a vector which isn't what this does. Changed to stringify(int flags). - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33746/#review82261 ----------------------------------------------------------- On April 30, 2015, 10:27 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33746/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 10:27 p.m.) > > > Review request for mesos, Chi Zhang and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Improve logging of clone flags for linux_launcher. > > > Diffs > ----- > > src/linux/ns.hpp 87ff82c2efdf26f38b81f8440640bf04def05931 > src/slave/containerizer/linux_launcher.cpp > b9e22e3c70bed0c29e2ca8632411789d33f779a8 > > Diff: https://reviews.apache.org/r/33746/diff/ > > > Testing > ------- > > Example output: > > I0501 05:13:25.414758 7838 linux_launcher.cpp:212] Cloning child process > with flags = CLONE_NEWNS | CLONE_NEWPID > > > Thanks, > > Ian Downes > >