----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/ -----------------------------------------------------------
(Updated May 12, 2015, 6:41 p.m.) Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu. Changes ------- Addressed Jie's comment about redundant tests. Removed tests: * `DropReserveNonMatchingRole` * `DropReserveNonMatchingPrincipal` * `DropReserveFrameworkMissingPrincipal` Since they'are already covered in `src/tests/master_validation_tests.cpp`. Migrated tests: * `DropReserveAsStaticReservation` * `DropUnreserveStaticReservation` to `src/tests/master_validation_tests.cpp` as * `TEST_F(ReserveOperationValidationTest, StaticReservation)` * `TEST_F(UnreserveOperationValidationTest, StaticReservation)` Bugs: MESOS-2489 https://issues.apache.org/jira/browse/MESOS-2489 Repository: mesos Description ------- See summary. Diffs (updated) ----- src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693 src/tests/master_validation_tests.cpp 1366bcd229f4cb62df7d181c42dae4152435bb14 src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/29748/diff/ Testing ------- make check Thanks, Michael Park