> On April 30, 2015, 4:09 p.m., Joe Smith wrote: > > docs/metrics.md, line 221 > > <https://reviews.apache.org/r/33241/diff/3/?file=938848#file938848line221> > > > > master/slave_shutdowns_completed > > > > These are slaves which were not heard from despite the slave-removal > > rate limit, and have been removed from the Master's slave registry. This is > > essentially the slave failing its health check.
Added > On April 30, 2015, 4:09 p.m., Joe Smith wrote: > > docs/metrics.md, line 225 > > <https://reviews.apache.org/r/33241/diff/3/?file=938848#file938848line225> > > > > These are slaves that are able to cleanly re-join the cluster and > > connect back to the master after the master is disconnected. Added > On April 30, 2015, 4:09 p.m., Joe Smith wrote: > > docs/metrics.md, line 232 > > <https://reviews.apache.org/r/33241/diff/3/?file=938848#file938848line232> > > > > These are slaves which are being removed for various reasons, including > > Maintenance. This metric will be broken out for > > https://issues.apache.org/jira/browse/MESOS-2485 Added in here for now > On April 30, 2015, 4:09 p.m., Joe Smith wrote: > > docs/metrics.md, line 246 > > <https://reviews.apache.org/r/33241/diff/3/?file=938848#file938848line246> > > > > Slaves which have failed their health check and are scheduled to be > > removed. They will not be immediately removed due to the Slave Removal > > Rate-Limit, but master/slave_shutdowns_completed will start increasing as > > they do get removed. Added > On April 30, 2015, 4:09 p.m., Joe Smith wrote: > > docs/metrics.md, line 255 > > <https://reviews.apache.org/r/33241/diff/3/?file=938848#file938848line255> > > > > This happens when the slave removal rate limit allows for a slave to > > reconnect and send a PONG to the master before being removed. Added - Ricardo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review82215 ----------------------------------------------------------- On May 12, 2015, 1:43 p.m., Ricardo Cervera-Navarro wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33241/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 1:43 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-2621 > https://issues.apache.org/jira/browse/MESOS-2621 > > > Repository: mesos > > > Description > ------- > > docs: Add documentation on observability metrics. > > > Diffs > ----- > > docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea > docs/metrics.md PRE-CREATION > > Diff: https://reviews.apache.org/r/33241/diff/ > > > Testing > ------- > > - Previewed in markdown editor. > - Replaced page content using the Element Inspector in Chrome to ensure that > the tables look good. > > > File Attachments > ---------------- > > mesosmetrics2.webarchive > > https://reviews.apache.org/media/uploaded/files/2015/04/27/b89946c8-f709-4bca-b610-affd584c62f3__mesosmetrics2.webarchive > > > Thanks, > > Ricardo Cervera-Navarro > >