----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34129/#review83524 -----------------------------------------------------------
You should update this help message for the http master/redirect: https://github.com/apache/mesos/blob/b2b03/src/master/http.cpp#L397-L398 Also, it would be super helpful to write a summary of how to use this feature to run mesos behind a proxy. This could go in docs/operational-guide.md - Jay Buffington On May 12, 2015, 4:30 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34129/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 4:30 p.m.) > > > Review request for mesos and Cosmin Lehene. > > > Bugs: MESOS-809 > https://issues.apache.org/jira/browse/MESOS-809 > > > Repository: mesos > > > Description > ------- > > If set, these IP/Port shall be advertised by libprocess (although bind is > not done on this IP/Port). If not set, libprocess advertises the IP/Port > on which bind was done. > > Command line arguments added: > public_ip: Public IP address to reach mesos. Defaults to the command line > argument `ip`. > public_port: Public port to reach mesos. Defaults to the command line > argument `port`. > > > Diffs > ----- > > docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b > src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd > > Diff: https://reviews.apache.org/r/34129/diff/ > > > Testing > ------- > > Testing: > make test > > > Thanks, > > Anindya Sinha > >
