> On Feb. 11, 2015, 5:27 a.m., Adam B wrote: > > src/tests/hook_tests.cpp, lines 302-305 > > <https://reviews.apache.org/r/29947/diff/7/?file=837751#file837751line302> > > > > Did you consider just sending an explicit ShutdownExecutorMessage from > > the slave to the executor? Then you can wait around for the hook to > > complete without worrying about the master/slave/framework shutting down in > > the meantime. > > Kapil Arya wrote: > I haven't considered the explicit message. I will try to find a prior > example and adjust accordingly.
Since we have already decoupled shutdown with successful execution of the hook, is this issue still relevant? - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29947/#review71946 ----------------------------------------------------------- On May 13, 2015, 4:36 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29947/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 4:36 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-2226 > https://issues.apache.org/jira/browse/MESOS-2226 > > > Repository: mesos > > > Description > ------- > > There is currently no good way to synchronize between the test body and the > hook code, so we wire a promise (owned by the test code). The technical debt > is covered by the following JIRA issue: > > https://issues.apache.org/jira/browse/MESOS-2641 > > > Diffs > ----- > > src/examples/test_hook_module.cpp b25830ab6475f997422cfd2f60cc9a79e1acadfe > src/messages/messages.proto 98d859f3db6013a2e155d838f590a0cde6dc5ed5 > src/tests/hook_tests.cpp a65c0ab7c41ec3b7964f9d572381fa3e61746dc3 > > Diff: https://reviews.apache.org/r/29947/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
