----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018/#review84222 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Hindman On May 17, 2015, 10:11 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34018/ > ----------------------------------------------------------- > > (Updated May 17, 2015, 10:11 a.m.) > > > Review request for mesos, Benjamin Hindman and Joris Van Remoortere. > > > Bugs: MESOS-2670 > https://issues.apache.org/jira/browse/MESOS-2670 > > > Repository: mesos > > > Description > ------- > > According Joris advice, replace the 'lambda::bind' expressions match these > rules: > > 1. Binds to a static function without any side-effects. > 2. Is self contained (i.e. does not rely on contextual parameters) > 3. Does not bind in any arguments. (i.e. only uses lambda::_N for arguments) > 4. Is only called in 1 place OR is so small that it is ok to repeat the code. > > > Diffs > ----- > > src/linux/cgroups.cpp df3211a0c25d7a16f36814886d14f81caaef2b9c > src/log/network.hpp 7c74a55cc2a71fa2acd207605f972e7fbd203be4 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 6a5b2b5c6e2844fe1a10815956569194b6f56681 > src/slave/containerizer/isolators/cgroups/mem.cpp > 2c218b2b83cf42f54dbc7ec4c2ba8960b6e194de > src/slave/containerizer/isolators/network/port_mapping.cpp > a4abaff30bb4646b1b1edfdbbc243c9e3f6851df > src/slave/containerizer/mesos/containerizer.cpp > b644b9c74bc23cf78c0a53284544be6cdaef2f8a > > Diff: https://reviews.apache.org/r/34018/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > >
