> On May 20, 2015, 11:47 a.m., Alexander Rojas wrote: > > src/examples/test_hook_module.cpp, lines 36-38 > > <https://reviews.apache.org/r/34361/diff/1/?file=962951#file962951line36> > > > > This constants are used nowhere but in one method. Is there any reason > > why they are not defined in the method itself or at least as static > > attributes of the TestHook class?
There's a mitigating circumstance for these declarations, there's a comment a few lines up from the change instructing that these should be kept in sync with the values in src/tests/hook_tests.cpp. Presumably they haven't been pulled into a separate file because it would make the example less self-contained. Bringing the names and types in sync with the ones created in hook_tests.cpp, but leaving them where they are. > On May 20, 2015, 11:47 a.m., Alexander Rojas wrote: > > src/tests/hook_tests.cpp, lines 74-77 > > <https://reviews.apache.org/r/34361/diff/1/?file=962952#file962952line74> > > > > ditto. > > > > Now there are 200 lines between definition and usage. If I am debugging > > or just checking the code, I'll have to scroll all the way up to see the > > values. ditto - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/#review84498 ----------------------------------------------------------- On May 18, 2015, 5:01 p.m., Colin Williams wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34361/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 5:01 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-2637 > https://issues.apache.org/jira/browse/MESOS-2637 > > > Repository: mesos > > > Description > ------- > > converted hard-coded strings to consts > > > Diffs > ----- > > src/examples/test_hook_module.cpp b25830ab6475f997422cfd2f60cc9a79e1acadfe > src/tests/hook_tests.cpp a65c0ab7c41ec3b7964f9d572381fa3e61746dc3 > src/tests/master_tests.cpp ba3858fb3026f2cc7af0523bd1a0c541eeafc34b > src/tests/slave_tests.cpp acae49731ff17103b529cdf828a63d9d55668549 > > Diff: https://reviews.apache.org/r/34361/diff/ > > > Testing > ------- > > > Thanks, > > Colin Williams > >
