----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review84908 -----------------------------------------------------------
First pass. 3rdparty/libprocess/include/process/http.hpp <https://reviews.apache.org/r/30032/#comment136354> Alternatively you could just use a naked constant and then sizeof(buffer) below. Declaring the constant does not add any information. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/30032/#comment136355> s/tc/tm There seems to be no call to stat here, so how can this comment be correct? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/30032/#comment136357> Why Result and not Try? Why not propagate the error from mtime? Why snake_case and not camelCase? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/30032/#comment136358> Why not report the error here? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/30032/#comment136361> Can we call this in NotModified above? See also the comments there, which also apply here, since this seems to be the same code. 3rdparty/libprocess/src/tests/process_tests.cpp <https://reviews.apache.org/r/30032/#comment136366> Insert blank above comment. 3rdparty/libprocess/src/tests/process_tests.cpp <https://reviews.apache.org/r/30032/#comment136367> Insert blank above comment and below last line of which it applies to. irst pass - Bernd Mathiske On May 18, 2015, 9:20 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30032/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 9:20 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, > Michael Park, and Till Toenshoff. > > > Bugs: mesos-708 > https://issues.apache.org/jira/browse/mesos-708 > > > Repository: mesos > > > Description > ------- > > When serving a static file, libprocess returns the header `Last-Modified` > which is used by browsers to control Cache. > When a http request arrives containing the header `If-Modified-Since`, a > response `304 Not Modified` is returned if the date in the request and the > modification time (as returned by doing `stat` in the file) coincide. > Unit tests added. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > bba62b393dc863e724cb602b1504eb6517ae9730 > 3rdparty/libprocess/src/process.cpp > e3de3cd6b536aaaf59784360aed546512dd04dc9 > 3rdparty/libprocess/src/tests/process_tests.cpp > 67e582cc250a9767a389e2bd0cc68985477f3ffb > > Diff: https://reviews.apache.org/r/30032/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
