> On May 19, 2015, 12:17 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp, line 72 > > <https://reviews.apache.org/r/34268/diff/1/?file=961220#file961220line72> > > > > Could you please explain why the standard implementation of this > > function would not work for Solaris?
getline is a GNU C library extension and not available by default on many Unix paltforms including Solaris. STL version proposed for Solaris can be used for everything as fully portable implementation unless there are use cases where performance can be a factor. - Stan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review84202 ----------------------------------------------------------- On May 19, 2015, 12:21 a.m., Stan Teresen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34268/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 12:21 a.m.) > > > Review request for mesos, Joris Van Remoortere and Till Toenshoff. > > > Repository: mesos-incubating > > > Description > ------- > > stout library - adding support for Solaris > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp d2ca4be > 3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp 86949ec > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp b0ed5cc > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 81d64cc > > Diff: https://reviews.apache.org/r/34268/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > adding missing new file: stout/os/sunos.hpp > > https://reviews.apache.org/media/uploaded/files/2015/05/15/a2e296fa-e251-4467-9873-77d8ced7f0a3__sunos.hpp > > > Thanks, > > Stan Teresen > >
