> On May 22, 2015, 8:50 p.m., Marco Massenzio wrote: > > include/mesos/slave/oversubscription.proto, line 49 > > <https://reviews.apache.org/r/34581/diff/2/?file=969904#file969904line49> > > > > I have some concerns about this design - given the Note above, this > > would imply that we would have multiple fields, each with its own message > > type (eg, `Freeze`, `Resize`, etc. etc.) > > > > Can't we just define some sort of base `ActionInfo` type, which may be > > extensible (maybe, even have an `ExtraInfo`). > > > > Been a while since I last played with protobuf at Google, but my > > concern is the potential growth of fields/types that this approach seem to > > entail.
This is a union pattern we used consistently in the code base. For example, the new API (include/mesos/scheduler/scheduler.proto), Offer.Operation, etc. I think this is more explicit (thus more readable IMO) comparing to a more general ActionInfo type. What do you think? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review84988 ----------------------------------------------------------- On May 22, 2015, 7:46 p.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34581/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 7:46 p.m.) > > > Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod > Kone. > > > Bugs: MESOS-2760 > https://issues.apache.org/jira/browse/MESOS-2760 > > > Repository: mesos > > > Description > ------- > > This proto describes a QoS correction message for particular executor or task. > It is a generic message between QoS Controller and slave. > > Additionaly, updated Makefile to include this proto during compilation. > > This request updates the https://reviews.apache.org/r/34571/ > > > Diffs > ----- > > include/mesos/slave/oversubscription.proto PRE-CREATION > src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 > > Diff: https://reviews.apache.org/r/34581/diff/ > > > Testing > ------- > > * make check > * run mesos: > 1) build (make) > 2) checked that *oversubscription.pb.h* and *oversubscription.pb.cc* are in > the proper directories > 3) run *mesos-slave*, *mesos-master* and checked if their behaviour is proper > > > Thanks, > > Bartek Plotka > >
