> On May 20, 2015, 5:50 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 157 > > <https://reviews.apache.org/r/34319/diff/3/?file=962168#file962168line157> > > > > Btw after looking at your other patches, I realize we don't really need > > hasenv anymore right? And I see you've been replacing hasenv with getenv, I > > think why not just remove hasenv all together? > > Greg Mann wrote: > Good call! I think that os::getenv().isSome() eliminates the need for > os::hasenv. I can remove it and update the patches.
Done. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/#review84553 ----------------------------------------------------------- On May 17, 2015, 1:40 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34319/ > ----------------------------------------------------------- > > (Updated May 17, 2015, 1:40 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-994 > https://issues.apache.org/jira/browse/MESOS-994 > > > Repository: mesos > > > Description > ------- > > Refactored os::getenv to return an option and updated os::path accordingly. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > d2ca4be90edb134465751d093b61e84fd6b16f1c > > Diff: https://reviews.apache.org/r/34319/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
