----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/#review85225 -----------------------------------------------------------
src/Makefile.am <https://reviews.apache.org/r/34662/#comment136757> Why have both? src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/34662/#comment136758> Newline before src/tests/resource_estimator.hpp <https://reviews.apache.org/r/34662/#comment136756> kill newline src/tests/resource_estimator.hpp <https://reviews.apache.org/r/34662/#comment136739> Put { on a newline Why have create take flags? We tried to make it only take a string. src/tests/resource_estimator_module.cpp <https://reviews.apache.org/r/34662/#comment136742> 2 space indent src/tests/resource_estimator_module.cpp <https://reviews.apache.org/r/34662/#comment136741> Skip the ' - ' or kill the 'for unit tests' to be consistent with the other test modules - Niklas Nielsen On May 25, 2015, 10:29 p.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34662/ > ----------------------------------------------------------- > > (Updated May 25, 2015, 10:29 p.m.) > > > Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod > Kone. > > > Bugs: MESOS-2650 > https://issues.apache.org/jira/browse/MESOS-2650 > > > Repository: mesos > > > Description > ------- > > Added *ResourceEstimator* (RE) module interface. > Added *TestResourceEstimator* example module. (Noop *ResourceEstimator* > module) > Moved *TestResourceEstimator* to seperate file from *tests/mesos.hpp* > Added *DummyTestResourceEstimator* module for unit tests purpose. (Module > with *TestResourceEstimator* logic - that's why it has to be in seperate file) > Changed *oversubscription_tests* to be typed_tested (for normal RE and RE > module) > > NOTE: The example modules were good enough for other modules' unit tests, > however RE had to be extended - to push particular *Resources* to slave. > That's why it was necessary to add new "Dummy" *TestResourceEstimator* module. > > In future if we implement https://issues.apache.org/jira/browse/MESOS-2764, > we will be able to inject stubed *Resources* in better way. > > > Diffs > ----- > > include/mesos/module/resource_estimator.hpp PRE-CREATION > src/Makefile.am 814468e3c5c750a6649b5eeb7c7f945f9e025c19 > src/examples/test_resource_estimator_module.cpp PRE-CREATION > src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be > src/tests/mesos.hpp b8f7a2f9236166e42421d926718af8d45e857eba > src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8 > src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29 > src/tests/oversubscription_tests.cpp > 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 > src/tests/resource_estimator.hpp PRE-CREATION > src/tests/resource_estimator_module.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34662/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bartek Plotka > >
