> On May 28, 2015, 7:51 a.m., Adam B wrote: > > src/master/http.cpp, line 1044 > > <https://reviews.apache.org/r/34646/diff/1/?file=971274#file971274line1044> > > > > The JIRA suggests that this case should not return OK (200), unless it > > queries the active master to return the actual tasks list. Otherwise, if > > it's going to return a blank tasks[] array, then it should return something > > like a 500 (Internal Server Error), or 307 (Temporary Redirect).
@adam-mesos I update the patch again. Feel sorry to misunderstand the issue before. Could you review again? Thank you very much. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/#review85528 ----------------------------------------------------------- On June 1, 2015, 6:35 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34646/ > ----------------------------------------------------------- > > (Updated June 1, 2015, 6:35 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-1865 > https://issues.apache.org/jira/browse/MESOS-1865 > > > Repository: mesos > > > Description > ------- > > Return empty task list when current master is not a leader. > > > Diffs > ----- > > src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 > > Diff: https://reviews.apache.org/r/34646/diff/ > > > Testing > ------- > > make check > > when current master is not a leader, it would redirect to the leader master. > > ``` > $ curl -i http://master1:5050/master/tasks.json > HTTP/1.1 307 Temporary Redirect > Date: Mon, 01 Jun 2015 06:30:08 GMT > Location: http://master2:5050//master/tasks.json > Content-Length: 0 > ``` > > > Thanks, > > haosdent huang > >
