----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/#review86029 -----------------------------------------------------------
src/linux/routing/queueing/fq_codel.cpp <https://reviews.apache.org/r/34830/#comment137878> This seems irrelavent to the purpose of this patch. Could you please split it out. BTW, this change is related to https://reviews.apache.org/r/34426/ (see the summary part of the comments). src/linux/routing/queueing/internal.hpp <https://reviews.apache.org/r/34830/#comment137885> OK, this is confusing to me. We return false in the following two cases: 1) link does not exist 2) qdisc already exists Is that expected? - Jie Yu On May 30, 2015, 9 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34830/ > ----------------------------------------------------------- > > (Updated May 30, 2015, 9 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-2781 > https://issues.apache.org/jira/browse/MESOS-2781 > > > Repository: mesos > > > Description > ------- > > Fix routing ingress/fq_codel search returning wrong qdisc. > > Add new checking to verify that operations occur on the correct interface and > change the behaviour of create() operation to return false rather than an > error if creation fails if the interface does not exist (now consistent with > exists() and remove()). > > > Diffs > ----- > > src/linux/routing/queueing/fq_codel.hpp > 7de1e31d4c43ac9cbffab1e472ea51140719f900 > src/linux/routing/queueing/fq_codel.cpp > 64b5c73e8cfa672141ddb663e879c58b4babfdbc > src/linux/routing/queueing/ingress.hpp > 84506fecd01522471a7998176c28bea8f1367aed > src/linux/routing/queueing/ingress.cpp > ae0c38d2215e7fabcc1060e7385484bd455e1699 > src/linux/routing/queueing/internal.hpp > d43a9fd405af2e59dc57cfc7ba9b5e77cb9f6b70 > > Diff: https://reviews.apache.org/r/34830/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
