> On June 3, 2015, 8:33 p.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, line 185 > > <https://reviews.apache.org/r/34911/diff/1/?file=975987#file975987line185> > > > > Do you only want to start the executor on oversubscribed resources or > > split it between task and executor? (Which I guess should be the common use > > case)
Now both task and executor should use revocable resources. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review86477 ----------------------------------------------------------- On June 1, 2015, 11:15 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34911/ > ----------------------------------------------------------- > > (Updated June 1, 2015, 11:15 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2753 > https://issues.apache.org/jira/browse/MESOS-2753 > > > Repository: mesos > > > Description > ------- > > An end to end test that launches a revocable executor. > > Note that this doesn't exercise cpu isolator because it uses the test > containerizer. Cpu isolator with revocable resources is already tested. > > BenM is writing an example framework that should test this with cpu isolator. > > > Diffs > ----- > > src/master/validation.cpp 1793b0e16fc36ead147880ee06cda40b23fa0962 > src/slave/slave.cpp fdaaea42ca9afd4af197f89edb31678723e9acbc > src/tests/mesos.hpp ac986a0687a576a0bd5693c82b3c7d543aaa956b > src/tests/mesos.cpp 1d5639c85517229f3396b40f2d8bd421b2ed7325 > src/tests/oversubscription_tests.cpp > ea5857cb579aa904fd05530684bdde51a0b3f27f > > Diff: https://reviews.apache.org/r/34911/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
