> On June 13, 2015, 5:58 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 834 > > <https://reviews.apache.org/r/35330/diff/2/?file=983205#file983205line834> > > > > this too?
doesn't fit on 80 lines > On June 13, 2015, 5:58 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 852 > > <https://reviews.apache.org/r/35330/diff/2/?file=983205#file983205line852> > > > > Fix 80 line width? doesn't fit on 80 lines > On June 13, 2015, 5:58 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 887 > > <https://reviews.apache.org/r/35330/diff/2/?file=983205#file983205line887> > > > > I think you can use pop_front here to be more obvious no pop_front method on vectors - Lily ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/#review87802 ----------------------------------------------------------- On June 11, 2015, 9:39 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35330/ > ----------------------------------------------------------- > > (Updated June 11, 2015, 9:39 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2797 > https://issues.apache.org/jira/browse/MESOS-2797 > > > Repository: mesos > > > Description > ------- > > Capped number of parallel inspect instances on a docker ps call. > > > Diffs > ----- > > src/docker/docker.hpp 7790d0ff9a6b085025f595533c5f46b702447927 > src/docker/docker.cpp 71383294c6234d08b2156565b170ada329b8e30f > src/slave/constants.hpp 84927e589499e989249c217db571bbeb84a88af1 > > Diff: https://reviews.apache.org/r/35330/diff/ > > > Testing > ------- > > sudo ./mesos-tests.sh --gtest_filter="*DOCKER*" --gtest_break_on_failure > --gtest_shuffle --gtest_repeat=30 > > > Thanks, > > Lily Chen > >