> On June 17, 2015, 8:32 p.m., Till Toenshoff wrote: > > src/slave/containerizer/mesos/launch.cpp, line 221 > > <https://reviews.apache.org/r/35562/diff/1/?file=986460#file986460line221> > > > > Does this TODO refer to a "clean environment" as being an environment > > without anything being set [envp={NULL}]? In any case, does it still make > > sense to have this TODO?
Ah, that TODO actually gets handled by a subsequent patch, the one that introduces the stripping, i.e., a "clean environment". ;-) I'll just leave it out and drop this issue unless you really would like me to delete the TODO in the subsequent review. :-p - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35562/#review88272 ----------------------------------------------------------- On June 17, 2015, 2:28 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35562/ > ----------------------------------------------------------- > > (Updated June 17, 2015, 2:28 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-2832 > https://issues.apache.org/jira/browse/MESOS-2832 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.cpp > 2f2d60e2011f60ec711d3b29fd2c157e30c83c34 > > Diff: https://reviews.apache.org/r/35562/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
