----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review88393 -----------------------------------------------------------
Michael, there are some artifacts in the patch, could you please rebase it one more time? 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (lines 104 - 112) <https://reviews.apache.org/r/35433/#comment140909> Ditto. docs/mesos-frameworks.md (lines 29 - 30) <https://reviews.apache.org/r/35433/#comment140908> Artifact? This was recently removed. - Alexander Rukletsov On June 18, 2015, 5:01 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35433/ > ----------------------------------------------------------- > > (Updated June 18, 2015, 5:01 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos > > > Description > ------- > > No bug was observed (yet), but realized I forgot about this in the dynamic > reservations patches. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 1e7aed0b48b8889eb8d042cbd9f907303d2510d3 > docs/mesos-frameworks.md 60405b16bfcb4be2fb0424d66d70d38c87c10d2a > include/mesos/mesos.proto 8df1211165169c9595e0e6e85b5ddc404345ff70 > src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 > src/docker/docker.hpp fbae7bd382b675bba602494f0aa8679797c41504 > src/docker/docker.cpp 4e1300300392b404b6dcf62631492112fa4939ba > src/hook/manager.hpp 47e8eb7d54d55049d054cf9b1225e67333f22adc > src/hook/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf > src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d > src/scheduler/scheduler.cpp 1efc6fb351e49deaa8f626823592bc9155f5137b > src/slave/containerizer/containerizer.cpp > c5ffc49899976225e319f122cb5f7556c3b09d46 > src/slave/containerizer/isolators/network/port_mapping.hpp > 7777ee869ce71a68f51d58159c701d3c5d1e502b > src/slave/containerizer/isolators/network/port_mapping.cpp > 137cdc9b064b02e829af857cff7b9023ee7b7b16 > src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b > src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 > src/slave/slave.hpp f1cf3b85ccb3eaf614fe844c830f7cc44f7916fe > src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b > src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 > src/tests/mesos.cpp 2cd2435eba4f911867e7e09338aa28e65b2d1f14 > src/tests/oversubscription_tests.cpp > c7a2dacb600d7703de6090e7e47f453a3d08b53a > src/tests/port_mapping_tests.cpp 6caab134fdbf3894f9fae801daf9491a13888c7d > support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c > > Diff: https://reviews.apache.org/r/35433/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >