> On March 13, 2015, 5:11 p.m., Alexander Rukletsov wrote: > > src/slave/slave.cpp, lines 537-538 > > <https://reviews.apache.org/r/31838/diff/2/?file=888587#file888587line537> > > > > Does it make sense to flatten this for readability? Like this: > > ``` > > } else if (info.has_id()) { > > ... > > } else { > > ... > > } > > ```
I like the idea of flattening the else if. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31838/#review76464 ----------------------------------------------------------- On March 8, 2015, 5:54 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31838/ > ----------------------------------------------------------- > > (Updated March 8, 2015, 5:54 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Vinod > Kone. > > > Bugs: MESOS-2464 > https://issues.apache.org/jira/browse/MESOS-2464 > > > Repository: mesos-incubating > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/slave/slave.cpp 364d911 > > Diff: https://reviews.apache.org/r/31838/diff/ > > > Testing > ------- > > make check && functional testing with failed authentication > > > Thanks, > > Till Toenshoff > >
