----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35816/#review89179 -----------------------------------------------------------
Patch looks great! Reviews applied: [35816] All tests passed. - Mesos ReviewBot On June 24, 2015, 3:35 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35816/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 3:35 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Fixed the incorrect `CHECK_EQ` introduced in > [r35699](https://reviews.apache.org/r/35699/). > > From @bmahler: > > Whoops, Jie just noticed that this isn't correct because > > 'updatedAllocation' is for the framework only, whereas 'total' and > > 'available' are for all frameworks on the slave. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > ef18ff850addfb5ce3500ed28e8ffd801e2d24eb > src/tests/hierarchical_allocator_tests.cpp > 3258840135290cd008ca09235d18b7f093dafd2e > > Diff: https://reviews.apache.org/r/35816/diff/ > > > Testing > ------- > > (1) Added a test > `HierarchicalAllocatorTest.UpdateAllocationMultipleFrameworks` which breaks > the previous `CHECK_EQ` condition. > (2) `make check` > > > Thanks, > > Michael Park > >
