> On June 24, 2015, 2:21 a.m., haosdent huang wrote: > > src/tests/master_contender_detector_tests.cpp, line 844 > > <https://reviews.apache.org/r/35815/diff/2/?file=990950#file990950line844> > > > > Oh, you are follow the test case before.
this doesn't make it right :) Fixed (both places) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35815/#review89122 ----------------------------------------------------------- On June 24, 2015, 1:15 a.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35815/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 1:15 a.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-2898 > https://issues.apache.org/jira/browse/MESOS-2898 > > > Repository: mesos > > > Description > ------- > > As of Mesos 0.24, we will support JSON format > for the MasterInfo information written out to > ZooKeeper for the Leader election process. > > This tests that the JSON can be correctly parsed > and the correct MasterInfo information retrieved. > > Jira: MESOS-2898 > > > Diffs > ----- > > src/tests/master_contender_detector_tests.cpp > 1b30eeb51520da7a5834768ac88a88a8a84fd976 > > Diff: https://reviews.apache.org/r/35815/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >
