> On June 23, 2015, 12:35 a.m., Till Toenshoff wrote: > > src/tests/containerizer.cpp, lines 127-128 > > <https://reviews.apache.org/r/35567/diff/2/?file=988913#file988913line127> > > > > Cant follow this one - are you saying that `executorEnvironment(..)` > > should possibly set environment variables?
I enhanced the comment. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35567/#review88780 ----------------------------------------------------------- On June 24, 2015, 10:01 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35567/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 10:01 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-2832 > https://issues.apache.org/jira/browse/MESOS-2832 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/containerizer.cpp > c5ffc49899976225e319f122cb5f7556c3b09d46 > src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b > src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 > src/tests/containerizer.cpp 68c6f989ce2f786771ee2286c98077bd59f4db44 > src/tests/slave_tests.cpp 027da84e5776cb3e98cf23a179238fbe75417d1a > > Diff: https://reviews.apache.org/r/35567/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
