----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35743/#review89303 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp (lines 341 - 345) <https://reviews.apache.org/r/35743/#comment141892> Let's try to avoid proliferating 'const' qualifiers on all of our locally scoped variables, as to do it consistently would be very verbose. For example, you didn't do it to the const 'load' result from flags.load below. Perhaps for this particular case, since it resembles a literal constant, we could keep 'const' and call it VALUES. Some food for thought. - Ben Mahler On June 25, 2015, 12:29 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35743/ > ----------------------------------------------------------- > > (Updated June 25, 2015, 12:29 a.m.) > > > Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Till > Toenshoff. > > > Repository: mesos > > > Description > ------- > > Changes: > - replacing argument arrays with static initializers in tests. > - making the argument 'argv' const in load method to reflect the semantics. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > 7584cb871d02ad01021f0c3439ea205736d4f6b4 > 3rdparty/libprocess/3rdparty/stout/include/stout/utils.hpp > 09a1dcd3b3a082544d221fbfeab9a3d3d9f85e2f > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp > c2c6a6ac97044f2317418295f48d75e94de4112b > > Diff: https://reviews.apache.org/r/35743/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > >
