----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35889/#review89603 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/tests/ssl_client.cpp (line 60) <https://reviews.apache.org/r/35889/#comment142249> Another option would be to stick this in an SSLClientTest test fixture which could "hold" the 'flags'. 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 708) <https://reviews.apache.org/r/35889/#comment142250> Please comment which this 'endif' closes! - Benjamin Hindman On June 27, 2015, 1:18 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35889/ > ----------------------------------------------------------- > > (Updated June 27, 2015, 1:18 a.m.) > > > Review request for mesos, Benjamin Hindman and Michael Park. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c781f6ca38d87c47b4bdadf5ac2f59a02dd8c73c > 3rdparty/libprocess/src/libevent.hpp > a20f2c3323421fc31ee1368989351bc96ce02a0e > 3rdparty/libprocess/src/openssl.cpp > 090e98584acd45d2ee3dcb1c1d09a46287a159e1 > 3rdparty/libprocess/src/tests/ssl_client.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/ssl_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/35889/diff/ > > > Testing > ------- > > make check with --enable-ssl --enable-libevent. > > > Thanks, > > Joris Van Remoortere > >
