----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/#review90677 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 24) <https://reviews.apache.org/r/35998/#comment143810> I know that in many other places we have written "Basic abstraction", but this really adds no meaning. So let's stop that! And we don't deal with just about any file system here (e.g. FAT32), do we? Suggestion: "Represents UNIX file systems paths and offers common path manipulations." Or something like that :-) 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 39) <https://reviews.apache.org/r/35998/#comment143811> Do you mean std::basename()? 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 48) <https://reviews.apache.org/r/35998/#comment143816> It would be good to explain why we are opting this way. How is this useful? OK, maybe nobody knows and we don't want to touch the code? There are various other inexplicable outcomes here. 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 52) <https://reviews.apache.org/r/35998/#comment143812> Component -> The component 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 53) <https://reviews.apache.org/r/35998/#comment143815> Why suddenly `slash` and not '/' as before? - Bernd Mathiske On June 29, 2015, 4:43 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35998/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 4:43 a.m.) > > > Review request for mesos, Bernd Mathiske and Joerg Schad. > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp > a4afdad0b5f053186ace4d6a37b41cd02e7d415b > > Diff: https://reviews.apache.org/r/35998/diff/ > > > Testing > ------- > > > Thanks, > > Till Toenshoff > >
