> On June 29, 2015, 5:14 p.m., Adam B wrote: > > docs/persistent-volume.md, line 169 > > <https://reviews.apache.org/r/35981/diff/1/?file=994064#file994064line169> > > > > There is no `volumes` field. Just a `resources` field, where each > > resource in the list must contain a `disk.volume` to be destroyed. > > Michael Park wrote: > I was actually referring to: > > ``` > message Create { > repeated Resource volumes = 1; > } > ```
I see, so the inconsistency was in the example json, not in the comment. Dropping this issue in favor of new ones. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review89827 ----------------------------------------------------------- On June 29, 2015, 10:59 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35981/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 10:59 p.m.) > > > Review request for mesos, Adam B, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2405 > https://issues.apache.org/jira/browse/MESOS-2405 > > > Repository: mesos > > > Description > ------- > > The Github rendered version is available [here]( > https://github.com/mesosphere/mesos/blob/user-docs/docs/persistent-volume.md) > > > Diffs > ----- > > docs/persistent-volume.md PRE-CREATION > > Diff: https://reviews.apache.org/r/35981/diff/ > > > Testing > ------- > > Documentation. > > > Thanks, > > Michael Park > >
