----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36204/#review90727 -----------------------------------------------------------
Ship it! LGTM! Could you please add a follow up patch to test this code path? src/slave/slave.cpp (lines 4382 - 4383) <https://reviews.apache.org/r/36204/#comment143863> You should just add a CHECK here: ``` CHECK_SOME(totalResources) << "Failed to apply checkpointed resource " << checkpointedResources << " to slave's resources " << info->resources(); usage->mutable_total()->CopyFrom(totalResources.get()); ``` - Jie Yu On July 7, 2015, 4:20 p.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36204/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 4:20 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Niklas Nielsen, Szymon Konefal, > and Vinod Kone. > > > Bugs: MESOS-2933 > https://issues.apache.org/jira/browse/MESOS-2933 > > > Repository: mesos > > > Description > ------- > > Pass slave's total resources to the ResourceEstimator and QoSController via > Slave::usage(). > > > Diffs > ----- > > include/mesos/mesos.proto 3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273 > src/slave/slave.cpp 008170f4ce7b97eda43b50b48083b32ae65925c0 > > Diff: https://reviews.apache.org/r/36204/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Bartek Plotka > >
