----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/#review90769 -----------------------------------------------------------
Patch looks great! Reviews applied: [35986] All tests passed. - Mesos ReviewBot On July 7, 2015, 7:07 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35986/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 7:07 p.m.) > > > Review request for mesos, Adam B and Isabel Jimenez. > > > Bugs: MESOS-2868 > https://issues.apache.org/jira/browse/MESOS-2868 > > > Repository: mesos > > > Description > ------- > > Allow slave attributes flag take a value with ':'. > > > Diffs > ----- > > src/common/attributes.cpp aab114e1a5932e3f218b850e1afc7f2ef0f10e21 > src/tests/attributes_tests.cpp 2e10eaf3c33e418603ea19090bb0bf9179af71f7 > > Diff: https://reviews.apache.org/r/35986/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > >