----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36275/#review90792 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 312) <https://reviews.apache.org/r/36275/#comment143919> I think a brief comment here and below on why we need to do a `bind` is helpful. - Benjamin Hindman On July 7, 2015, 9:02 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36275/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 9:02 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael > Park. > > > Bugs: MESOS-3005 > https://issues.apache.org/jira/browse/MESOS-3005 > > > Repository: mesos > > > Description > ------- > > We generate the certificate using the hostname associated with > INADDR_LOOPBACK and explicitly bind the test server on INADDR_LOOPBACK. This > way there is no inconsistency with the hostname of the certificate versus the > test. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 869ed6572392e3cdcf0c0152bcca4b91130e3c04 > > Diff: https://reviews.apache.org/r/36275/diff/ > > > Testing > ------- > > make check. > verifying on other dev's systems. > > > Thanks, > > Joris Van Remoortere > >
