> On July 7, 2015, 12:05 a.m., Timothy Chen wrote: > > Thanks for adding the hook! There is one more code path that a docker > > container can be launched, which is in launchExecutorProcess. > > Can you add the hook call in that path as well?
Hi, @tnachen I update the patch. Could you review again, thank you very much. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review90610 ----------------------------------------------------------- On July 8, 2015, 5:06 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36185/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 5:06 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2588 > https://issues.apache.org/jira/browse/MESOS-2588 > > > Repository: mesos > > > Description > ------- > > Create pre-launch hook before a docker container launches in slave. > > > Diffs > ----- > > include/mesos/hook.hpp 0995c249e9f07c6c4a26d1c5c369d48bb8056f1f > src/examples/test_hook_module.cpp d61cd557d8e44e5089f324edf97b0335a4ededab > src/hook/manager.hpp 47e8eb7d54d55049d054cf9b1225e67333f22adc > src/hook/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf > src/slave/containerizer/docker.cpp cfb60177fe48ec0eeab12ff392c6c9f89634b92f > src/tests/docker_containerizer_tests.cpp > a3da786c1b733e9dd4abf1d02d5dae051393d921 > > Diff: https://reviews.apache.org/r/36185/diff/ > > > Testing > ------- > > # Add a new unit test > "DockerContainerizerTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook" > make check -j8 GTEST_FILTER=-"*" > sudo ./bin/mesos-tests.sh --verbose > --gtest_filter=DockerContainerizerTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook > > > Thanks, > > haosdent huang > >
