> On July 8, 2015, 11:44 p.m., Vinod Kone wrote: > > Are you sure we cannot use major, minor and patch? How come we havent > > encountered an issue so far?
They are private member variables with no accessors. Previously, we just used the comparison operations built into the Version class but these will give the wrong results for installations where the 3.x kernels have been renamed as 2.6.40+x to avoid some legacy compatability bugs. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36336/#review91023 ----------------------------------------------------------- On July 8, 2015, 10:50 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36336/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 10:50 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, > Kapil Arya, and Vinod Kone. > > > Bugs: MESOS-3020 > https://issues.apache.org/jira/browse/MESOS-3020 > > > Repository: mesos > > > Description > ------- > > Expose major, minor and patch components from stout Version > > Note: The names major and minor are not available when compiling with GCC > because it pulls in the sysmacros.h header implicitly which define these for > makedev. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp > 8692323d28131cd5706dde0503d49f8f0b0a1aeb > > Diff: https://reviews.apache.org/r/36336/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Paul Brett > >
