----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/#review91100 -----------------------------------------------------------
Ship it! Will fix the below issue while comitting. 3rdparty/libprocess/src/time.cpp (line 1) <https://reviews.apache.org/r/34703/#comment144366> This misses the “Apache License Version 2.0” header - see our style-guide on "File Headers". ``` /** * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License */ ``` - Till Toenshoff On June 17, 2015, 3:42 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34703/ > ----------------------------------------------------------- > > (Updated June 17, 2015, 3:42 p.m.) > > > Review request for mesos, Bernd Mathiske, Michael Park, Nikita Vetoshkin, and > Till Toenshoff. > > > Bugs: mesos-708 > https://issues.apache.org/jira/browse/mesos-708 > > > Repository: mesos > > > Description > ------- > > Adds some manipulator classes which allows formatting Time objects to > ostreams. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c781f6ca38d87c47b4bdadf5ac2f59a02dd8c73c > 3rdparty/libprocess/include/process/time.hpp > c5ab2a3cfa83590eb6612152ae365dd67f51cea9 > 3rdparty/libprocess/src/tests/time_tests.cpp > be314182c65c05d439b81aa5248a71d93f6f0a0b > 3rdparty/libprocess/src/time.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34703/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
