----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34139/#review91154 -----------------------------------------------------------
tests!? src/slave/containerizer/provisioners/appc/discovery.hpp (line 36) <https://reviews.apache.org/r/34139/#comment144435> This class and methods all need commenting! src/slave/containerizer/provisioners/appc/discovery.hpp (line 50) <https://reviews.apache.org/r/34139/#comment144437> comments. src/slave/containerizer/provisioners/appc/discovery.hpp (line 68) <https://reviews.apache.org/r/34139/#comment144438> comments. src/slave/containerizer/provisioners/appc/discovery.cpp (line 60) <https://reviews.apache.org/r/34139/#comment144443> +1 please make sure that code in a review only depends on stuff in the current review and its dependent reviews. it's hard to review o.w. - Vinod Kone On July 7, 2015, 7:42 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34139/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 7:42 p.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Local and simple discovery only. > > > Diffs > ----- > > src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 > src/slave/containerizer/provisioners/appc/discovery.hpp PRE-CREATION > src/slave/containerizer/provisioners/appc/discovery.cpp PRE-CREATION > src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b > src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 > > Diff: https://reviews.apache.org/r/34139/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
