> On July 8, 2015, 9:57 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.hpp, line 230 > > <https://reviews.apache.org/r/36326/diff/3/?file=1002973#file1002973line230> > > > > I dont' think we need to expose this.
Since the method is a bit long, kept it but replaced other "usage" methods with lamdas. > On July 8, 2015, 9:57 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 1239 > > <https://reviews.apache.org/r/36326/diff/3/?file=1002974#file1002974line1239> > > > > It's probably not going to be used outside of usage, so I think it's > > safe to inline this in _usage, and if you do want a seperate method this > > probably don't need to be exposed too. same comments as above. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91005 ----------------------------------------------------------- On July 9, 2015, 8:38 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36326/ > ----------------------------------------------------------- > > (Updated July 9, 2015, 8:38 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2951 > https://issues.apache.org/jira/browse/MESOS-2951 > > > Repository: mesos > > > Description > ------- > > WIP > > Adding cgroups cpustat and memory statistics as preferred way to get usage > statistics for containerizers. > > Jira: MESOS-2951 > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 646a277be21deaded47324bea5474bd68699f25f > src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba > > Diff: https://reviews.apache.org/r/36326/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > >
