> On July 9, 2015, 9:26 p.m., Vinod Kone wrote: > > Can you make sure to test this with a 22.x driver and 23.x master for > > completeness?
Good call, did a manual test by modifying the test framework in 0.22.0 to do reconciliation against a master off head with this fix, parses the message correctly: ``` $ ./src/test-framework --master=10.35.255.108:5050 I0709 22:00:26.220700 14160 sched.cpp:157] Version: 0.22.0 I0709 22:00:26.228389 14202 sched.cpp:254] New master detected at master@10.35.255.108:5050 I0709 22:00:26.229192 14202 sched.cpp:264] No credentials provided. Attempting to register without authentication I0709 22:00:26.233379 14210 sched.cpp:448] Framework registered with 20150709-214514-1828659978-5050-3855-0001 Registered! Task 1 is in state TASK_LOST Aborting because task 1 is in unexpected state TASK_LOST with reason 9 from source 0 with message 'Reconciliation: Task is unknown' I0709 22:00:26.235369 14212 sched.cpp:1623] Asked to abort the driver I0709 22:00:26.235436 14212 sched.cpp:856] Aborting framework '20150709-214514-1828659978-5050-3855-0001' I0709 22:00:26.235656 14160 sched.cpp:1589] Asked to stop the driver ``` - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36361/#review91203 ----------------------------------------------------------- On July 9, 2015, 6:55 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36361/ > ----------------------------------------------------------- > > (Updated July 9, 2015, 6:55 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3025 > https://issues.apache.org/jira/browse/MESOS-3025 > > > Repository: mesos > > > Description > ------- > > See MESOS-3025 for details. > > > Diffs > ----- > > src/common/protobuf_utils.cpp 8a51daa45db312ca4608dda3fd99df2c3f9962f1 > src/master/master.cpp 35e147574842e3c6ae819541a6c03bf16a375294 > src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d > src/scheduler/scheduler.cpp d5ac04cb4549e5ef886ff3c01fff414083a63c06 > > Diff: https://reviews.apache.org/r/36361/diff/ > > > Testing > ------- > > make check > > Existing test coverage encompasses this. > > > Thanks, > > Ben Mahler > >
