> On July 13, 2015, 6:14 p.m., Anand Mazumdar wrote: > > a few fly-by general comments.
thanks! > On July 13, 2015, 6:14 p.m., Anand Mazumdar wrote: > > src/master/main.cpp, line 205 > > <https://reviews.apache.org/r/36425/diff/2/?file=1009590#file1009590line205> > > > > Can we align this similar to the one you have already done a few lines > > before ? because of the way this gets indented (which was, in fact, my initial approach) it looks really horrible (also, it does the `jagged` look we so dread :) ) This way is much more pleasing on the eye, whilst not impacting at all on readability (IMO). > On July 13, 2015, 6:14 p.m., Anand Mazumdar wrote: > > src/master/main.cpp, line 209 > > <https://reviews.apache.org/r/36425/diff/2/?file=1009590#file1009590line209> > > > > Can we use our already existing abstraction stringify(...) here or did > > it not work here ? mah - this is the "standard" way of doing it (I think our `stringify` was necessary prior to C++11 and `std::to_string()`, but I may be wrong here). anyways - changed to stringify(). - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review91496 ----------------------------------------------------------- On July 13, 2015, 4:35 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36425/ > ----------------------------------------------------------- > > (Updated July 13, 2015, 4:35 p.m.) > > > Review request for mesos, Benjamin Hindman and Cody Maloney. > > > Bugs: MESOS-2902 > https://issues.apache.org/jira/browse/MESOS-2902 > > > Repository: mesos > > > Description > ------- > > Jira: MESOS-2902 > > It is sometimes useful to enable an external script to > configure the IP address the Mesos Master will bind to > on the server, where it's not desirable to set the > --ip flag and/or a "wrapper" script is not a viable option. > > This patch adds a --ip_discovery_script to point to a local > script that will emit as its only output the IP address that > the Master will bind to: only spaces and newlines are allowed; > further, as we cannot use the `libprocess` sub-processing > facilities, we cannot timeout the script, should this block > for long times (or even forever). > > This will override the --ip flag, which, even if set, will be > ignored. > > > Diffs > ----- > > docs/configuration.md feee5594c88112f77ce382cb3dd8628653f92d01 > src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 > > Diff: https://reviews.apache.org/r/36425/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >
