----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review91891 -----------------------------------------------------------
src/launcher/fetcher.cpp (line 135) <https://reviews.apache.org/r/36547/#comment145601> Suggestion: put the condition check for the protocol AFTER checking if we have an error. Then we do not need the comment above nor the extra variable AND we can state in the error message which specific protocol is meant instead of "HTTP/FTP". - Bernd Mathiske On July 16, 2015, 7:48 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36547/ > ----------------------------------------------------------- > > (Updated July 16, 2015, 7:48 a.m.) > > > Review request for mesos, Bernd Mathiske and Joerg Schad. > > > Bugs: MESOS-3060 > https://issues.apache.org/jira/browse/MESOS-3060 > > > Repository: mesos > > > Description > ------- > > The response code for successful FTP file transfers is 226, while it is 200 > for HTTP. The fetcher has been changed to check for a response code of 226 > for FTP URIs. > > > Diffs > ----- > > src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd > > Diff: https://reviews.apache.org/r/36547/diff/ > > > Testing > ------- > > make check & external FTP server test. > > > Thanks, > > Jan Schlicht > >
