----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/#review92195 -----------------------------------------------------------
Bad patch! Reviews applied: [36596] Failed command: ./support/apply-review.sh -n -r 36596 Error: 2015-07-19 00:57:57 URL:https://reviews.apache.org/r/36596/diff/raw/ [8815/8815] -> "36596.patch" [1] Successfully applied: Added jsonify() to stout. The jsonify() function converts a Protobuf/string/double/bool to JSON::Value. Added some tests as well. Review: https://reviews.apache.org/r/36596 Checking 2 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo Total errors found: 0 ERROR: Commit spanning multiple projects. Please use separate commits for mesos, libprocess and stout. Paths grouped by project: stout: 3rdparty/libprocess/3rdparty/stout/Makefile.am 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp 3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp libprocess: 3rdparty/libprocess/3rdparty/Makefile.am Failed to commit patch - Mesos ReviewBot On July 19, 2015, 12:38 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36585/ > ----------------------------------------------------------- > > (Updated July 19, 2015, 12:38 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen. > > > Bugs: MESOS-3061 > https://issues.apache.org/jira/browse/MESOS-3061 > > > Repository: mesos > > > Description > ------- > > This would allow Mesos-DNS to lookup container information such as its > IP address. > > NOTE: Apparently, the data size is about 15KB per `docker inspect` blob and > that might addup for large clusters. One suggestion is to expose only the IP > field(s) from: > > "NetworkSettings": { > "Bridge": "", > "EndpointID": > "c9d8bfb120503eda3dc88ffdcc5778cff4e7f05bb2e53f9b2fba82972ecfe3da", > "Gateway": "172.17.42.1", > "GlobalIPv6Address": "", > "GlobalIPv6PrefixLen": 0, > "HairpinMode": false, > "IPAddress": "172.17.0.5", > "IPPrefixLen": 16, > "IPv6Gateway": "", > "LinkLocalIPv6Address": "", > "LinkLocalIPv6PrefixLen": 0, > "MacAddress": "02:42:ac:11:00:05", > "NetworkID": > "f36472f7725507d90ab10215d35d020bf3eaf5ebdc024cb5b3ffff773967d9fc", > "PortMapping": null, > "Ports": {}, > "SandboxKey": "/var/run/docker/netns/3c3d4d0f5e18", > "SecondaryIPAddresses": null, > "SecondaryIPv6Addresses": null > }, > > An alternate is to use a hook module to decorate TaskStatus with IP > information extracted from the output of `docker inspect`. > > > Diffs > ----- > > src/docker/executor.cpp cdcd8ee7ad0b53748819bc1e565f708e30e99a5d > src/tests/docker_containerizer_tests.cpp > 6c6f4b7f30cec9b5bba77234b714e96289c82b43 > > Diff: https://reviews.apache.org/r/36585/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Kapil Arya > >
