----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36574/#review92463 -----------------------------------------------------------
Ship it! src/tests/mesos.hpp (line 1382) <https://reviews.apache.org/r/36574/#comment146658> We should really move this to src/common/protobuf_utils.cpp. - Benjamin Hindman On July 21, 2015, 4:45 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36574/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 4:45 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-3076 > https://issues.apache.org/jira/browse/MESOS-3076 > > > Repository: mesos > > > Description > ------- > > * createLabel(key, value) return a new "key":"value" Label. > > > Diffs > ----- > > src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db > src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc > src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 > src/tests/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901 > > Diff: https://reviews.apache.org/r/36574/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
