----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/#review92534 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/openssl.cpp (line 489) <https://reviews.apache.org/r/36656/#comment146739> Can we leave a longer comment as to why we do this? Maybe link to something if that's helpful? Maybe even include a quick comment where we define the flags why we specifically omit v2 there as well? It'll be helpful to leave a nice trail of breadcrumbs so someone else doesn't come and try and re-add it. 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 674) <https://reviews.apache.org/r/36656/#comment146740> We missed some! s/openssl/OpenSSL/ ;-) Here and throughout please. - Benjamin Hindman On July 21, 2015, 10:51 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36656/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 10:51 p.m.) > > > Review request for mesos, Benjamin Hindman and Michael Park. > > > Bugs: MESOS-3121 > https://issues.apache.org/jira/browse/MESOS-3121 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/openssl.hpp > 3f8d351589f8bb26c886da12c53b5e02a242376a > 3rdparty/libprocess/src/openssl.cpp > 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 2fe50601615b0bee57bd3e05dc9c932f93ca7477 > > Diff: https://reviews.apache.org/r/36656/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Joris Van Remoortere > >
