-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36629/#review92537
-----------------------------------------------------------

Ship it!


Great, can we do the 70 character comment wraps here though? Thanks!


3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp (line 165)
<https://reviews.apache.org/r/36629/#comment146743>

    s/support/supported/



3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp (line 177)
<https://reviews.apache.org/r/36629/#comment146744>

    Can we use pointers here and below please? Thanks!



3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp (line 210)
<https://reviews.apache.org/r/36629/#comment146746>

    Newline before we start this comment and the one below?



3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp (line 230)
<https://reviews.apache.org/r/36629/#comment146745>

    Awesome awesome awesome sauce.


- Benjamin Hindman


On July 21, 2015, 1:11 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36629/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 1:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp 
> e40ec55f7818fad8703787ecb67869c9e1922e85 
> 
> Diff: https://reviews.apache.org/r/36629/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Reply via email to