----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36674/#review92541 -----------------------------------------------------------
include/mesos/executor.hpp (line 243) <https://reviews.apache.org/r/36674/#comment146750> s/execute/executed/ I would rewrite this: Mutex for enforcing serial execution of all non-callbacks. include/mesos/scheduler.hpp (line 452) <https://reviews.apache.org/r/36674/#comment146752> ditto. - Artem Harutyunyan On July 21, 2015, 9:07 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36674/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 9:07 p.m.) > > > Review request for mesos, Benjamin Hindman and Michael Park. > > > Bugs: MESOS-3120 > https://issues.apache.org/jira/browse/MESOS-3120 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/executor.hpp f3cd3ccd505ed4b308a1a42b238fc21fe45cc3b3 > include/mesos/scheduler.hpp 9dae0a8f5af168f25eb462e30473f8fd7da50913 > src/exec/exec.cpp a1ae074b962d8e93ab7776bd624389857da486f3 > src/sched/sched.cpp 25e2d660f4ee4c0b21c887f78ad04819012966f9 > > Diff: https://reviews.apache.org/r/36674/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >