----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36718/#review92849 -----------------------------------------------------------
Patch looks great! Reviews applied: [36718] All tests passed. - Mesos ReviewBot On July 23, 2015, 11:24 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36718/ > ----------------------------------------------------------- > > (Updated July 23, 2015, 11:24 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-3115 > https://issues.apache.org/jira/browse/MESOS-3115 > > > Repository: mesos > > > Description > ------- > > Protobufs are preferred over C structs for public API. > > > Diffs > ----- > > include/mesos/slave/isolator.hpp 85e38f5e4aa66527f1756fa259b93389f45028b3 > include/mesos/slave/isolator.proto PRE-CREATION > src/Makefile.am 489ddb424b342635c3dbc4d14ff5d69ce76a237b > src/common/protobuf_utils.hpp 2e827a0923de83d5cf853a12435b451cc7c55891 > src/common/protobuf_utils.cpp e0f82b53f5e106bbf4e21d6ac946df0fae821882 > src/exec/exec.cpp a1ae074b962d8e93ab7776bd624389857da486f3 > src/slave/containerizer/isolator.cpp > 278824c0cb662bb09150e8cb5a72dafef034e6fb > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 2118c97d4f3d2e58fab62c6e99d5bec6f4df8bbd > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 750bef947c11eb55236ac46109b9dd97e62b453d > src/slave/containerizer/isolators/cgroups/mem.hpp > dc752014236b69d34c6b33a06fc00580780b0b4c > src/slave/containerizer/isolators/cgroups/mem.cpp > b0e343fdc7088b2895d5dc8bb416dbcbf241cae5 > src/slave/containerizer/isolators/cgroups/perf_event.hpp > 560cd0359a2795a937335efa30dc380a60fcb540 > src/slave/containerizer/isolators/cgroups/perf_event.cpp > 512df3be7fdf6bac22ad4122f54a21d9986a1a6a > src/slave/containerizer/isolators/filesystem/posix.hpp > 16ba26f4f5b515acbeb3c4d514d4eecf2f277df8 > src/slave/containerizer/isolators/filesystem/posix.cpp > 0c5662741a7562872f0dbfaf9c9b6d923d80af5d > src/slave/containerizer/isolators/filesystem/shared.hpp > 4d7d9a9e310cb636dc4983de86e9e4c9321104ea > src/slave/containerizer/isolators/filesystem/shared.cpp > 24f30746be7b5be95a4d8f442a3a5464d1f0f2a0 > src/slave/containerizer/isolators/namespaces/pid.hpp > 9cda3fd418d0f0df4d12ed1367da277b81866103 > src/slave/containerizer/isolators/namespaces/pid.cpp > 5de0791a835d725b7c7aae1ba585a94cff9372f1 > src/slave/containerizer/isolators/network/port_mapping.hpp > 6b5cf62838637e9759935f9edf0c152a035005fe > src/slave/containerizer/isolators/network/port_mapping.cpp > a7757f2a51f04da27645074f048722c22a2be752 > src/slave/containerizer/isolators/posix.hpp > 271061ef97aea96bb816982e530c84554d4b08d8 > src/slave/containerizer/isolators/posix/disk.hpp > 5dfa815edaee9b17c19ae2a7491e63c545c8ab1f > src/slave/containerizer/isolators/posix/disk.cpp > b2f995cba36b1399db48af1de49d76c607f80abd > src/slave/containerizer/launcher.cpp > 24df1ca5f7407062f9e7b4bfa18f2cae5c72e140 > src/slave/containerizer/linux_launcher.cpp > 790e392645dd62e74b03ff0771f6bf0e9efeb622 > src/slave/containerizer/mesos/containerizer.hpp > f6c580d1b629ee799977cc8824f337764d893c5f > src/slave/containerizer/mesos/containerizer.cpp > 609620c4322e41562597ee682b311cd320bca6d2 > src/tests/containerizer_tests.cpp 88c46e7214f4d92b7d6a9b433a3a0497681dc6db > src/tests/isolator.hpp fd6aec74edf49153d31b559d56e8e06c15836f68 > > Diff: https://reviews.apache.org/r/36718/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
